Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

Update GdkPixbuf #243

Merged
merged 2 commits into from
Jan 4, 2021
Merged

Update GdkPixbuf #243

merged 2 commits into from
Jan 4, 2021

Conversation

pbor
Copy link
Contributor

@pbor pbor commented Jan 3, 2021

Shows the generated files if gtk-rs/gir-files#72
is merged

@pbor pbor changed the title WIP: uddate GdkPixbuf WIP: update GdkPixbuf Jan 3, 2021
@pbor pbor force-pushed the pixbuf branch 3 times, most recently from 7aa6adf to 5cf7ee3 Compare January 3, 2021 17:55
@sdroege
Copy link
Member

sdroege commented Jan 3, 2021

Looks good to me generally

@pbor pbor changed the title WIP: update GdkPixbuf Update GdkPixbuf Jan 3, 2021
@sdroege
Copy link
Member

sdroege commented Jan 3, 2021

The CI failure looks relevant:

 diff --git b/glib/src/gobject/auto/binding.rs a/glib/src/gobject/auto/binding.rs
index 0236115..afcac6e 100644
--- b/glib/src/gobject/auto/binding.rs
+++ a/glib/src/gobject/auto/binding.rs
@@ -41,7 +41,7 @@ impl Binding {
     #[doc(alias = "g_binding_unbind")]
     pub fn unbind(&self) {
         unsafe {
-            gobject_ffi::g_binding_unbind(self.to_glib_none().0);
+            gobject_ffi::g_binding_unbind(self.to_glib_full());
         }
     }
 }

Looks like gtk-rs/gir-files#66 somehow was reverted?

This change was overwritten by mistake in 1c4aa4d
@pbor
Copy link
Contributor Author

pbor commented Jan 4, 2021

I have readded the gobject change in its own commit

@sdroege
Copy link
Member

sdroege commented Jan 4, 2021

I have readded the gobject change in its own commit

How did it get lost though? :)

@pbor
Copy link
Contributor Author

pbor commented Jan 4, 2021

I have readded the gobject change in its own commit

How did it get lost though? :)

No idea... it was lost in a regen commit back in November that I linked in the commit message

@sdroege
Copy link
Member

sdroege commented Jan 4, 2021

@GuillaumeGomez You broke it ;)

@GuillaumeGomez
Copy link
Member

Someone summoned me?

@sdroege sdroege merged commit 20bafd5 into gtk-rs:master Jan 4, 2021
@sdroege sdroege linked an issue Jan 4, 2021 that may be closed by this pull request
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bind types needed for implementing a pixbuf loader
3 participants