-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Various fixes to EventManager
s
#4639
Various fixes to EventManager
s
#4639
Conversation
0a5edb9
to
e076926
Compare
It seems a few things in the all-sky coinc offline workflow actually depend on |
e076926
to
3c8e5a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. It will break things downstream in the PyGRB workflow, but it should be easy to fix and will simplify the code.
* Rename "snr_<detector>" datasets to just "snr" * Do not store template duration in trigger files * Cleanup and better document `write_events()` method * Fix how gating info is written * Fix imports * Detriplicate code * Codeclimate
* Rename "snr_<detector>" datasets to just "snr" * Do not store template duration in trigger files * Cleanup and better document `write_events()` method * Fix how gating info is written * Fix imports * Detriplicate code * Codeclimate
* Rename "snr_<detector>" datasets to just "snr" * Do not store template duration in trigger files * Cleanup and better document `write_events()` method * Fix how gating info is written * Fix imports * Detriplicate code * Codeclimate
This addresses, at least in part, #4416 and #4632.
It only affects the HDF5 output of
pycbc_multi_inspiral
, specifically:snr_*
datasets are renamed to justsnr
. This will break code downstream ofpycbc_multi_inspiral
, which will have to be modified (probably in a later PR though).template_duration
dataset is removed, the idea being that template parameters should always be taken from the bank file instead. Note that a few plotting codes in the all-sky offline search workflow do needtemplate_duration
to be in the trigger files. I think the main reason for this is that not every bank generation code adds the template duration dataset when generating the bank, so historically this has been done inpycbc_inspiral
instead. I added a comment to explain this next to the relevant code inEventManager
. I think this is not ideal, so we should try to avoid this in PyGRB workflows.I have broken down the changes into small and logically-meaningful commits, hopefully this makes review easier and faster.