You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I tried to collect the offline dataset of an online trained model using the _obtain_steps function. I found an error there, in lines 694-697, where two parenthesis are missing inside the file: scope-rl/scope-rl/dataset/synthetic.py
Secondly, there is a variable rollout_lengths (line 704), which causes an error in line 723 within the for loop. However, since there are no examples with _obtain_steps, I could not compare this. A quick solution was to simply change it from: for rollout_step in rollout_lengths[i]:to forrollout_step in range(rollout_lengths[i]):`
Note: I have now successfully trained an offline RL model with the _obtain_steps function. Let me know if I can contribute in any way :)
The text was updated successfully, but these errors were encountered:
Thank you for reaching out with the issues and solutions! The codes (both lines 694-697 and line 723) should definitely be fixed as you mentioned. Could you make a PR with the suggested update? We appreciate your help in improving the software.
alexofficial
pushed a commit
to alexofficial/scope-rl
that referenced
this issue
Mar 6, 2024
The error occurred when the for loop was used with `rollout_lengths[i]`,
where `rollout_lengths` was created with `self.random_.choice()`,
resulting in a `numpy.int32` object.
The problem has been fixed by iterating directly over the range of `rollout_lengths[i]` instead.
Fixing errors with _obtain_steps function hakuhodo-technologies#27
Hi,
I tried to collect the offline dataset of an online trained model using the _obtain_steps function. I found an error there, in lines 694-697, where two parenthesis are missing inside the file: scope-rl/scope-rl/dataset/synthetic.py
The solution is:
Secondly, there is a variable rollout_lengths (line 704), which causes an error in line 723 within the for loop. However, since there are no examples with _obtain_steps, I could not compare this. A quick solution was to simply change it from:
for rollout_step in
rollout_lengths[i]:to for
rollout_step in range(rollout_lengths[i]):`Note: I have now successfully trained an offline RL model with the _obtain_steps function. Let me know if I can contribute in any way :)
The text was updated successfully, but these errors were encountered: