Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

DiagramTextProvider.supports*() methods are never called #140

Closed
steghoja opened this issue Sep 27, 2021 · 1 comment
Closed

DiagramTextProvider.supports*() methods are never called #140

steghoja opened this issue Sep 27, 2021 · 1 comment

Comments

@steghoja
Copy link

Starting from 1.1.25, the supportsEditor(), supportsView(), and supportsSelection() methods are no longer called. The DiagramTextIntentProvider gets the text from the DiagramTextProvider without checking these methods first. That means that a DiagramTextProvider implementation could provide bogus diagram text that is not suitable for the current selection.

Another side effect is that the diagram gets overwritten when focus switches to the PlantUML view. This makes navigating that view almost impossible.

I can reliably reproduce this issue with Eclipse Capra when switching from 1.1.24 to 1.1.25 or 1.1.26, so I'd consider this a regression.
steghoja pushed a commit to steghoja/plantuml that referenced this issue Sep 27, 2021
Fix hallvard#140: check if view and selection supported
5efdbb0 
This patch introduces a change to the DiagramTextIntentProvider to
check if the DiagramTextProvider supports the current view and
selection. This makes sure that only DiagramTextProviders that should
contribute a diagram do so.
@travkin79
Copy link
Collaborator

Seems to be fixed in release 1.1.27

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@travkin79 @steghoja