Skip to content

Commit

Permalink
Fix hallvard#140: check if view and selection supported
Browse files Browse the repository at this point in the history
This patch introduces a change to the DiagramTextIntentProvider to
check if the DiagramTextProvider supports the current view and
selection. This makes sure that only DiagramTextProviders that should
contribute a diagram do so.
  • Loading branch information
Jan-Philipp Steghöfer committed Sep 27, 2021
1 parent 610d90d commit 5efdbb0
Showing 1 changed file with 10 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,19 @@ public Collection<DiagramIntent> getDiagramInfos(final DiagramIntentContext cont
// TODO
diagramText = diagramTextProvider2.getDiagramText((IEditorPart) workbenchPart, selection);
} else {
diagramText = diagramTextProvider.getDiagramText((IEditorPart) workbenchPart, selection);
if (diagramTextProvider.supportsEditor((IEditorPart) workbenchPart)
&& diagramTextProvider.supportsSelection(selection)) {
diagramText = diagramTextProvider.getDiagramText((IEditorPart) workbenchPart, selection);
}
}
} else if (workbenchPart instanceof IViewPart) {
diagramText = diagramTextProvider.getDiagramText((IViewPart) workbenchPart, selection);
if (diagramTextProvider.supportsView((IViewPart) workbenchPart)
&& diagramTextProvider.supportsSelection(selection)) {
diagramText = diagramTextProvider.getDiagramText((IViewPart) workbenchPart, selection);
}
}
} else if (context instanceof WorkspaceDiagramIntentProviderContext && diagramTextProvider instanceof DiagramTextProvider2) {
} else if (context instanceof WorkspaceDiagramIntentProviderContext
&& diagramTextProvider instanceof DiagramTextProvider2) {
final WorkspaceDiagramIntentProviderContext intentProviderContext = (WorkspaceDiagramIntentProviderContext) context;
final DiagramTextProvider2 diagramTextProvider2 = (DiagramTextProvider2) diagramTextProvider;
if (diagramTextProvider2.supportsPath(intentProviderContext.getPath())) {
Expand Down

0 comments on commit 5efdbb0

Please # to comment.