Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

feat: prompt to upgrade plugin when installing existing plugin #871

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 20, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

安装已存在插件时,支持提示和升级插件。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3164

Screenshots:

image

Special notes for your reviewer:

测试方式:

  1. Halo 需要切换到 Refine problem detail when plugin is already installed halo#3350 分支。
  2. 在插件为 deployment 模式下启动 Halo。
  3. 安装任意一个插件,然后继续上传安装相同插件。
  4. 观察是否提示升级此插件。

Does this PR introduce a user-facing change?

Console 端安装已存在插件时,支持提示并升级插件。

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 20, 2023
@vercel
Copy link

vercel bot commented Feb 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 21, 2023 at 2:29AM (UTC)

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

/approve

image

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2023
@LIlGG
Copy link
Member

LIlGG commented Feb 21, 2023

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot merged commit 4dd9592 into halo-dev:main Feb 21, 2023
@JohnNiang JohnNiang modified the milestones: 2.3.x, 2.3.0 Feb 21, 2023
@ruibaby ruibaby deleted the feat/install-exist-plugin branch February 21, 2023 04:18
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…dev/console#871)

#### What type of PR is this?

/kind feature

#### What this PR does / why we need it:

安装已存在插件时,支持提示和升级插件。

#### Which issue(s) this PR fixes:

Fixes halo-dev#3164

#### Screenshots:

<img width="1411" alt="image" src="https://user-images.githubusercontent.com/21301288/220118697-12fbd7a7-57e6-47bb-a03b-b9c280571687.png">

#### Special notes for your reviewer:

测试方式:

1. Halo 需要切换到 halo-dev#3350 分支。
2. 在插件为 deployment 模式下启动 Halo。
3. 安装任意一个插件,然后继续上传安装相同插件。
4. 观察是否提示升级此插件。

#### Does this PR introduce a user-facing change?

```release-note
Console 端安装已存在插件时,支持提示并升级插件。
```
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

重复安装已存在的插件时提示升级
4 participants