-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Refine problem detail when plugin is already installed #3350
Refine problem detail when plugin is already installed #3350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
#### What type of PR is this? /kind feature #### What this PR does / why we need it: 安装已存在插件时,支持提示和升级插件。 #### Which issue(s) this PR fixes: Fixes halo-dev/halo#3164 #### Screenshots: <img width="1411" alt="image" src="https://user-images.githubusercontent.com/21301288/220118697-12fbd7a7-57e6-47bb-a03b-b9c280571687.png"> #### Special notes for your reviewer: 测试方式: 1. Halo 需要切换到 halo-dev/halo#3350 分支。 2. 在插件为 deployment 模式下启动 Halo。 3. 安装任意一个插件,然后继续上传安装相同插件。 4. 观察是否提示升级此插件。 #### Does this PR introduce a user-facing change? ```release-note Console 端安装已存在插件时,支持提示并升级插件。 ```
…dev/console#871) #### What type of PR is this? /kind feature #### What this PR does / why we need it: 安装已存在插件时,支持提示和升级插件。 #### Which issue(s) this PR fixes: Fixes halo-dev#3164 #### Screenshots: <img width="1411" alt="image" src="https://user-images.githubusercontent.com/21301288/220118697-12fbd7a7-57e6-47bb-a03b-b9c280571687.png"> #### Special notes for your reviewer: 测试方式: 1. Halo 需要切换到 halo-dev#3350 分支。 2. 在插件为 deployment 模式下启动 Halo。 3. 安装任意一个插件,然后继续上传安装相同插件。 4. 观察是否提示升级此插件。 #### Does this PR introduce a user-facing change? ```release-note Console 端安装已存在插件时,支持提示并升级插件。 ```
What type of PR is this?
/kind improvement
/area core
What this PR does / why we need it:
This PR refines problem detail of PluginAlreadyExistsException. Please note the new type
https://halo.run/probs/plugin-alreay-exists
and additional propertypluginName
of problem detail.Meanwhile
Before
After
Which issue(s) this PR fixes:
Fixes #3164
Special notes for your reviewer:
Does this PR introduce a user-facing change?