Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

React demo doesnt install with node 10.x #145

Closed
sandys opened this issue Aug 3, 2019 · 1 comment
Closed

React demo doesnt install with node 10.x #145

sandys opened this issue Aug 3, 2019 · 1 comment
Labels
example released

Comments

@sandys
Copy link

sandys commented Aug 3, 2019

just a plain yarn install in the react demo directory gives this error

[2/4] Fetching packages...
error hawk@0.10.2: The engine "node" is incompatible with this module. Expected version "0.8.x". Got "10.16.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
harttle added a commit that referenced this issue Aug 25, 2019
@harttle
fix: reactjs demo during yarn install, fixes #145
49a430e 
simply remove unused dependencies fixes this issue, but I removed
all package-lock.json / yarn.lock since the demo should always be
in sync with the codebase
harttle added a commit that referenced this issue Aug 26, 2019
@harttle
fix: reactjs demo during yarn install, fixes #145
84c3fa3 
simply remove unused dependencies fixes this issue, but I removed
all package-lock.json / yarn.lock since the demo should always be
in sync with the codebase
harttle pushed a commit that referenced this issue Aug 26, 2019
@semantic-release-bot
chore(release): 9.0.0 [skip ci]
c2ba1e1 
# [9.0.0](v8.5.3...v9.0.0) (2019-08-26)

### Bug Fixes

* break/continue omitting output before them, [#123](#123) ([ae45c46](ae45c46))
* reactjs demo during yarn install, fixes [#145](#145) ([b65df44](b65df44))

### Code Refactoring

* return value of Tag#render is no longer used ([8028f82](8028f82))

### Features

* renderSync, parseAndRenderSync and renderFileSync, see [#48](#48) ([7fb01ad](7fb01ad))

### Performance Improvements

* target to es6, fixes [#137](#137) ([3b9fc7e](3b9fc7e))

### BREAKING CHANGES

* Tag#render now returns void, use emitter argument
to write rendered html.
* ship to Node.js 8, the dist/liquid.cjs.js (main) nolonger
supports Node.js 6, other bundles are also provided via dist/liquid.esm.js, dist/liquid.js (ES5 umd) and liquid.min.js (minified ES5 umd)
* remove default export, now should be used like import
{Liquid} from 'liquidjs'
@harttle
Copy link
Owner

harttle commented Aug 26, 2019

🎉 This issue has been resolved in version 9.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
example released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sandys @harttle