Offer a renderSync method?

[zachleat]

Most templating engines offer synchronous render methods (ejs, mustache, handlebars, haml, pug, nunjucks, etc).

Does one exist for liquidjs? If not, could one be added?

(love this library btw—thank you)

[harttle]

Maybe not possible in current code base. We know async methods cannot be converted to sync. So we made intensive discussion over whether to support async in #3 .

Nevertheless, supporting sync render methods without regression would be great. Welcome to propose a solution for this issue.

[harttle]

Render could be implemented syncly, while the only reason to be async is Async Tags. Especially {%include%} and {%layout%}, and things like one could do some database manipulation during tag/filter rendering.

[zachleat]

Interesting! To be frank I think I’d be happy with throwing an error if the template has an async tag and rendering is in sync mode.

[zachleat]

I worked around this in my upstream code so it isn’t necessary for me any more! It may be useful for someone else in the future but I would consider it low priority. In fact, other libs might tend towards what you’ve done instead 😎 Thanks for the discussion!

[harttle]

Now we use TypeScript and I'll try make it support both async and sync calls, maybe generate additional code during rollup build.

[harttle]

renderFileSync, renderSync, parseAndRenderSync are now supported by v9.0.0, but with some breaking changes. Feel free to file an issue if there's problem during upgrade. Closing, hope it helps!

[Munawwar]

Ok I did a simple test of renderSync() and seems to be working. Integrated liquidjs with SahteReact (front-end library I was building for Shopify stores... so now, one can reuse shopify templates on the client-side co-existing with libraries like jquery!)

Munawwar/SahteReact@3251a21

@harttle how to include partials on browser (without async fetching)? how to use dynamicPartials?

[harttle]

By default, it's implemented as sync xhr which is absolutely bad practice. see:

liquidjs/src/fs/browser.ts

Line 47 in f661cd8

function readFileSync (url: string): string {

A customed, platform-related fs can be specified in the LiquidOptions, as discussed in #131