Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Set search input to readonly when disable_search_threshold is met #1294

Merged
merged 1 commit into from
Jun 25, 2013

Conversation

koenpunt
Copy link
Collaborator

Set search input to readonly when disable_search_threshold is met. Fixes #1293

pfiller added a commit that referenced this pull request Jun 25, 2013
Read-only search field when search is disabled.
@pfiller pfiller merged commit 8c57af3 into harvesthq:master Jun 25, 2013
@pfiller
Copy link
Contributor

pfiller commented Jun 25, 2013

Thanks @koenpunt - this is great.

@koenpunt
Copy link
Collaborator Author

There is one problem left, when using the down key to select an option the window scrolls where actually the event should be default prevented

@koenpunt
Copy link
Collaborator Author

Oh crap, chosen is jQuery 1.4+ but the .prop method is there since 1.6 so I'll update that soon

@koenpunt
Copy link
Collaborator Author

Fixed in #1311

@koenpunt koenpunt deleted the gh1293-disable-search-input branch June 28, 2013 16:41
pfiller added a commit that referenced this pull request Jul 2, 2013
Replace prop for jQuery legacy support #1311
Prevent default on arrow down #1309
Explicitly add files for gh-pages #1307
Fix RTL Disabled Search Issue #1300
Fix scroll bug in Prototype version #1301
Read-only search field when search is disabled. #1294
Remove Grunt-Bump #1280
Make sure Chosen isn't disabled before showing results. #1282
Fix choice build after update #1286
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Hide Search on Single Select" doesn't disable search
2 participants