Replace javascript:void(0) with #

[pfiller]

@kenearley @stof @koenpunt

Fixes:

• issues with content security policy (javascript:void(0) and Content Security Policy #1215)
• onbeforeunload in IE (window beforeunload triggered from chosen click, IE 8 & 9 #403)

We don't need to add a preventDefault because all clicks on .chzn-container already have a preventDefault

[kenearley]

Is there a reason it needs to be an anchor tag at all if it doesn't need an href? Would a span do just as well?

[koenpunt]

Agree with @kenearley

[pfiller]

I suppose there isn't a reason for it to be an anchor, but changing that is a much bigger change.

[kenearley]

[koenpunt]

And what if we leave out the href attribute?

[kenearley]

And what if we leave out the href attribute?

Ah yeah. That might be the better solution.

[pfiller]

Done and done. Works in IE8 even.

[pfiller]

While testing #1385, I noticed that the cursor doesn't change to pointer when you take the href away. That sucks and I think I'm inclined to just put the href back instead of adding style.

[kenearley]

I'm inclined to just put the href back instead of adding style.

Whatever works. It's not too big of a deal either way.