License link in footer to license #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| </ul> | ||
|
|
||
| <footer> | ||
| © 2011 <a href="http://www.getharvest.com/">Harvest</a> - Chosen is licensed under the <a href="http://en.wikipedia.org/wiki/MIT_License">MIT license</a>. | ||
| © 2011 <a href="http://www.getharvest.com/">Harvest</a> — Chosen is licensed under the <a href="https://github.com/harvesthq/chosen/blob/master/LICENSE.md">MIT license</a>. |
There was a problem hiding this comment.
Shouldn't this be 2013? Or 2011-2013?
There was a problem hiding this comment.
I actually looked into this. It allegedly should be earliest publish date, which is 2011. But mostly, it's all stupid. I gave pause, too, and I wouldn't want to imply that this isn't maintained because of the copyright year. I'd vote for 2011-2013, depending on @pfiller's opinion.
There was a problem hiding this comment.
My understanding is that you want the earliest publishing date as well as the years of any major revisions. Given that, I'd definitely vote for the year span. Even if it's wrong, I still prefer the "this is fresh content" signal of including the latest year.
2011-2013 it is.
|
|
pfiller
added a commit
that referenced
this pull request
Jul 24, 2013
Update copyright and license link
pfiller
added a commit
that referenced
this pull request
Jul 26, 2013
- CSS Updates #1368, #1371 - Prevent text selection on Chosen #1374 - single_backstroke_delete defaults to true #1375 - No longer expose classes to window context #1389 - Single select value fix #1392 - Remove javascript:void and attr references #1385, #1377 - Disable Chosen on iPhone / iPod and Android mobile devices by default #1388 - Add Destroy Method #1396 - Option to Hide Selected & Disabled Options #1404 - Always clear result highlight #1407 - Replace characters only once #1411 - Document all the things. #1366, #1376, #1383 - Add Gemfile for compass dependency #1373 - Update copyright and license link #1397 - Add @koenpunt as a maintainer #1399 - Add anchors to documentation headers #1395 - Updated stackoverflow instructions #1403
gitlost
pushed a commit
to gitlost/chosen
that referenced
this pull request
Nov 17, 2013
gitlost
pushed a commit
to gitlost/chosen
that referenced
this pull request
Nov 17, 2013
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linking the "MIT License" footer link to the Wikipedia page is a little weird. We should probably just link to the actual license.
(Also, some indentation and whitespace fixes.)