Fix broken Bower-Chosen process #2527
Conversation
`git tag -l` lists all tags in alphabetical order. As long as we're consistent* (that's the key) with our tagging, the last alphabetical version will also be the most recent version.
|
we could also update git in the before task? |
|
And leave the sorting as-is |
|
Because that's the problem here right? That the version of git on travis is not the latest? |
|
I now remember why I didn't use
|
I think I don't know what you mean with this? What are you referring to? |
|
@pfiller making an update in a few months: |
Nothing specific. Seems like we give an unreasonable proportion of this project's time to making things work for the Bower crowd. I'm mostly just being a krabby patty. |
|
So what now, we're prepping for a 2.0? With @mlettini's css-rework et al? |
|
I've spent a good amount of time reading through open issues and thinking about a philosophy for Chosen. We haven't had anything like that to this point and I think it's fair to say the project has grown quite stale as a result. I hate looking up and seeing 79 open PRs. I'm on vacation for the next two weeks, but I think it'd be nice to chat about a direction for Chosen when I get back. Would you be up for a Hangout then? |
|
Sounds like a plan! Just let me know when you're back. |
@harvesthq/chosen-developers
In #2449, the line that grabs our latest tag was changed to
git tag --sort=v:refname | tail -1. Unfortunately, that line errors out on Travis.Fortunately, we don't really need it.
git tag -llists all tags in alphabetical order. As long as we'reconsistent (that's the key) with our tagging, the last alphabetical version will also be the most recent version. That should be true going forward.
Simple change. What say you?