Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

install latest git to support version sorting #2528

Merged
merged 1 commit into from
Feb 18, 2016

Conversation

koenpunt
Copy link
Collaborator

@koenpunt koenpunt commented Feb 8, 2016

Followup on #2527

This enables docker based builds, and updates Git to the latest stable version, to support sorting based on version instead of alphabetically.

also set sudo to false to enable docker builds, which are way faster
@koenpunt
Copy link
Collaborator Author

koenpunt commented Feb 8, 2016

But I now see that using Docker doesn't really result in faster build times.. While testing it turns out that with the git install the build time is the same on both stacks. But the container stack has a shorter wait time until it's starting.

For reference;

Precise: https://travis-ci.org/harvesthq/chosen/builds/107869514
Container: https://travis-ci.org/harvesthq/chosen/builds/107867054

addons:
apt:
sources:
- git-core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure it can just be git by itself and not reference git-core anymore. git-core was a transitional name because of goofy reasons — it should now just be a dummy package that points to git as its only dependency.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git-core is the only one on the whitelist, so maybe it's true for regular apt, but not with the docker addons.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And these are sources, not packages, the package is simply git

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. It looks like that whitelist entry was only added 18 days ago in travis-ci/apt-source-safelist#225. This is fine with me then, because I don't feel like PR'ing the addition of git to the whitelist 😜

@pfiller
Copy link
Contributor

pfiller commented Feb 18, 2016

Coooooooooool with me. Thanks @koenpunt!

pfiller added a commit that referenced this pull request Feb 18, 2016
install latest git to support version sorting
@pfiller pfiller merged commit a9ea4c1 into harvesthq:master Feb 18, 2016
@koenpunt koenpunt deleted the latest-git branch February 18, 2016 19:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants