Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Add tentative AppVeyor configuration #59

Closed
wants to merge 1 commit into from
Closed

Add tentative AppVeyor configuration #59

wants to merge 1 commit into from

Conversation

AndreLouisCaron
Copy link
Contributor

@AndreLouisCaron AndreLouisCaron commented Apr 20, 2018

By request from @mavogel :-)

I think you'll need to set up AppVeyor on this repository in order to trigger your first build.

Note: this build does not run acceptance tests. There is preliminary support for that in #58 and probably more work to do since they don't pass on Windows (yet).

Edit: I tested this on my personal AppVeyor account by creating a dummy PR in my fork. Here is an example build output: AndreLouisCaron/terraform-provider-docker build 1.0.12.

@mavogel
Copy link
Contributor

mavogel commented Apr 20, 2018

Thank you very much @AndreLouisCaron for you PRs :)

I'll keep you updated

@AndreLouisCaron
Copy link
Contributor Author

Looks like we're still waiting on microsoft/go-winio#75...

@mavogel
Copy link
Contributor

mavogel commented Jul 5, 2018

Seems like we get progress on microsoft/go-winio#80 ...

@mavogel
Copy link
Contributor

mavogel commented Sep 24, 2018

@AndreLouisCaron how is the current status:

@AndreLouisCaron
Copy link
Contributor Author

Thanks for your patience! I'm just tried building and hit an error.

I ran:

$ cd terraform-provider-docker
$ git checkout master
$ git clean -xdf
$ git pull origin master
$ go get github.com/hashicorp/terraform/plugin
$ go build

When building, I get this error:

.\main.go:10:15: cannot use "github.com/terraform-providers/terraform-provider-docker/docker".Provider (type func() "github.com/terraform-providers/terraform-provider-docker/vendor/github.com/hashicorp/terraform/terraform".ResourceProvider) as type "github.com/hashicorp/terraform/plugin".ProviderFunc in field value

I'm not sure where I'm going wrong. Any ideas?

@mavogel
Copy link
Contributor

mavogel commented Sep 25, 2018

AFAIK the core of terraform is heavily refactored for version v0.12.0 and I assume that with

$ go get github.com/hashicorp/terraform/plugin

you pulled the latest version which has breaking changes. hashicorp/terraform/plugin is already in the vendor directory in version v0.10.0.
Did you try removing $GOPATH/github.com/hashicorp/terraform/plugin and try to rebuild the binary?

@AndreLouisCaron
Copy link
Contributor Author

AndreLouisCaron commented Sep 25, 2018

I initially ran go get because I was getting this output:

$ go build
main.go:4:2: cannot find package "github.com/hashicorp/terraform/plugin" in any of:
        C:\software\Go\src\github.com\hashicorp\terraform\plugin (from $GOROOT)
        C:\Users\André\.go\src\github.com\hashicorp\terraform\plugin (from $GOPATH)

When I remove it from GOPATH and rebuild, I get the same error again.

Seems like it's not finding stuff in the vendor folder. I checked the diff and it seems that even back in April, I had to do this before go install when running on AppVeyor. Any idea what I'm doing wrong?

@AndreLouisCaron
Copy link
Contributor Author

Well.. looks like I didn't check out the project under GOPATH. Just did that now and it builds. I'll try this PR again and follow up!

@AndreLouisCaron
Copy link
Contributor Author

OK, I managed to run the test suite with the latest version of go-winio. I'll submit a new PR that contains this change, #58 and the go-winio update. Once the build passes, you can re-evaluate.

@mavogel
Copy link
Contributor

mavogel commented Sep 25, 2018

replaced by #90

@mavogel mavogel closed this Sep 25, 2018
@mavogel mavogel mentioned this pull request Oct 19, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants