Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixing some words displayStrings_cs.properties #1454

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

slrslr
Copy link
Contributor

@slrslr slrslr commented Dec 4, 2024

It is pretty common that the node (a computer/server) is translated as uzel in czech language.
"Cryptoy" translation is a nonsense, for a cryptocurrency is used "kryptoměna" translation.

I have noticed that some variables like "shared.yourDepositTransactionId" are missing in this czech language file, but exist in original english file. As a layman user, I do not know about any convenient and fast way to merge all missing lines into a czech file so it is at a proper spot, not all at the end of file and so i can easily find and translate the merged lines. If you can not tell me the steps to do it ( I am on Linux), maybe do it yourself and i will then go through the CS file, find english strings and translate these.

@slrslr slrslr requested a review from woodser as a code owner December 4, 2024 18:59
@slrslr
Copy link
Contributor Author

slrslr commented Dec 4, 2024

How I could avoid https://github.com/haveno-dex/haveno/actions/runs/12166479027 or it was necessary to run like half hour and generate hundreds of MB data for each smallest text file modification?

@woodser woodser merged commit b586bc5 into haveno-dex:master Dec 5, 2024
4 of 5 checks passed
@woodser
Copy link
Contributor

woodser commented Dec 5, 2024

How I could avoid https://github.com/haveno-dex/haveno/actions/runs/12166479027 or it was necessary to run like half hour and generate hundreds of MB data for each smallest text file modification?

Yeah it runs the complete build including installers.

@slrslr
Copy link
Contributor Author

slrslr commented Dec 5, 2024

How I could avoid https://github.com/haveno-dex/haveno/actions/runs/12166479027 or it was necessary to run like half hour and generate hundreds of MB data for each smallest text file modification?

Regarding this HuggingChat AI suggests this to a maintainer of this repo:

  1. Talk to the maintainers: Reach out to the project maintainers and ask if they can optimize the CI/CD pipeline or provide guidance on how to minimize the build time.

  2. Use a GitHub Actions feature: GitHub Actions provides a feature called "Workflow optimization" that can help reduce the number of builds and tests. You can ask the maintainers to enable this feature.

and this to a PR submitter:

  1. Use a draft pull request: If you're not sure about the impact of your changes, consider creating a draft pull request. This will allow you to test the CI/CD pipeline without triggering a full build.

I am unsure if draft request is visible to the maintainer and he is notified about it.

merge all missing lines into a czech file

I guess you have no time for this since you have not replied.

@woodser
Copy link
Contributor

woodser commented Jan 6, 2025

Please submit a PR with the improvements to the Czech translation file. Thanks.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants