Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Big update displayStrings_cs.properties #1523

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

slrslr
Copy link
Contributor

@slrslr slrslr commented Jan 6, 2025

Since @woodser ignored the second paragraph in my initial post of the PR #1454 , so I have spent/wasted some time in getting a Linux bash script which helped me to partly synchronize outdated Haveno czech language file with english original file and then i have spend around 8 hours manually fixing issues (tens of strings were missing, many out of order, hundreds of line wrapping errors and many strings were orphan) resulting in decent quality czech file. Please use it.
And please consider a good practice of using translation service #1506 instead of continuously wasting time of the translators synchronizing the files (many do not know how to, possibly that is the reason why the czech Haveno was incompletely translated (tens of strings missing) or redundant.

Woodser wanted to waste more of my time to bother me with this PR as a layman causing possibly tens of minutes of time and power to build whole software just for this PR.

@slrslr slrslr requested a review from woodser as a code owner January 6, 2025 14:56
@woodser
Copy link
Contributor

woodser commented Jan 6, 2025

Woodser wanted to waste more of my time to bother me with this PR as a layman causing possibly tens of minutes of time and power to build whole software just for this PR.

You know this is just a volunteer project, and if it's not you improving Czech translations, it will be someone else, probably me.

So any help you can offer for things you care about is welcome.

@woodser
Copy link
Contributor

woodser commented Jan 7, 2025

Sorry but a change to master has caused a merge conflict with your PR. Please resolve the conflict and then we can merge.

@woodser woodser merged commit 21ea08a into haveno-dex:master Jan 7, 2025
5 checks passed
@slrslr slrslr deleted the patch-2 branch January 7, 2025 11:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants