Skip to content

Commit

Permalink
fix: Ensure ordering of astradb inputs (langflow-ai#4552)
Browse files Browse the repository at this point in the history
  • Loading branch information
erichare authored and diogocabral committed Nov 26, 2024
1 parent 0bcc056 commit 656eb10
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/backend/base/langflow/components/vectorstores/astradb.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ class AstraVectorStoreComponent(LCVectorStoreComponent):
advanced=True,
),
DropdownInput(
name="embedding_service",
name="embedding_choice",
display_name="Embedding Model or Astra Vectorize",
info="Determines whether to use Astra Vectorize for the collection.",
options=["Embedding Model", "Astra Vectorize"],
Expand Down Expand Up @@ -239,7 +239,7 @@ def insert_in_dict(self, build_config, field_name, new_parameters):
return build_config

def update_build_config(self, build_config: dict, field_value: str, field_name: str | None = None):
if field_name == "embedding_service":
if field_name == "embedding_choice":
if field_value == "Astra Vectorize":
self.del_fields(build_config, ["embedding"])

Expand All @@ -252,7 +252,7 @@ def update_build_config(self, build_config: dict, field_value: str, field_name:
real_time_refresh=True,
).to_dict()

self.insert_in_dict(build_config, "embedding_service", {"embedding_provider": new_parameter})
self.insert_in_dict(build_config, "embedding_choice", {"embedding_provider": new_parameter})
else:
self.del_fields(
build_config,
Expand All @@ -273,7 +273,7 @@ def update_build_config(self, build_config: dict, field_value: str, field_name:
info="Allows an embedding model configuration.",
).to_dict()

self.insert_in_dict(build_config, "embedding_service", {"embedding": new_parameter})
self.insert_in_dict(build_config, "embedding_choice", {"embedding": new_parameter})

elif field_name == "embedding_provider":
self.del_fields(
Expand Down Expand Up @@ -410,7 +410,7 @@ def build_vector_store(self, vectorize_options=None):
msg = f"Invalid setup mode: {self.setup_mode}"
raise ValueError(msg) from e

if self.embedding_service == "Embedding Model":
if self.embedding_choice == "Embedding Model":
embedding_dict = {"embedding": self.embedding}
else:
from astrapy.info import CollectionVectorServiceOptions
Expand Down

0 comments on commit 656eb10

Please # to comment.