Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Ensure ordering of astradb inputs #4552

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Conversation

erichare
Copy link
Collaborator

This PR adjusts the naming of a dynamic input in the Astra DB Vector Store component to ensure its correct placement in the list.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 12, 2024
@dosubot dosubot bot added the bug Something isn't working label Nov 12, 2024
@erichare erichare enabled auto-merge (squash) November 12, 2024 21:42
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 12, 2024
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #4552 will degrade performances by 14.48%

Comparing fix-ordering-astradb-inputs (d4a1772) with main (aca2b4b)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-ordering-astradb-inputs Change
test_invalid_run_with_input_type_chat 16.4 ms 14 ms +17.3%
test_successful_run_with_output_type_any 454.3 ms 407.5 ms +11.48%
test_successful_run_with_output_type_debug 454 ms 530.8 ms -14.48%

@erichare erichare merged commit 70ebfc4 into main Nov 12, 2024
28 checks passed
@erichare erichare deleted the fix-ordering-astradb-inputs branch November 12, 2024 22:45
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants