Introduce tempfile improvements #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tempfile's newer version, 3.15.0 introduces security improvements that aim to prevent collisions. Therefore, we should probably not use a custom suffix anymore.
Ported from hermit-os#816, fixes a regression introduced by hermit-os/kernel#1529, which modified the Hermit kernel so that it uses absolute paths instead of relative ones.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #852 +/- ##
==========================================
+ Coverage 71.85% 71.87% +0.01%
==========================================
Files 23 23
Lines 3063 3065 +2
==========================================
+ Hits 2201 2203 +2
Misses 862 862 ☔ View full report in Codecov by Sentry. |
n0toose
commented
Jan 5, 2025
Nevermind, it is enabled by default. |
This was referenced Jan 6, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from #816, introduces a few improvements to our temporary file implementation.
The changes remove our custom UUID in our temporary directories, but introduce UUIDs in temporary files. A justification for this change is mentioned here: #816 (comment)