Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Version dependent operator whitespace function. #696

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

keriksson-rosenqvist-oqc
Copy link
Contributor

Solve a rename issue in pycodestyle.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.04% ⚠️

Comparison is base (5b9110b) 97.83% compared to head (36941c7) 97.79%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
- Coverage   97.83%   97.79%   -0.04%     
==========================================
  Files           1        1              
  Lines        2398     2402       +4     
==========================================
+ Hits         2346     2349       +3     
- Misses         52       53       +1     
Files Changed Coverage Δ
autopep8.py 97.79% <75.00%> (-0.04%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keriksson-rosenqvist-oqc
Copy link
Contributor Author

The missed line in the diff coverage is what's used when running a version of Python that is not supported by pycodestyle >= 2.11.0. It is used in the Python package/ build (3.7) action.

bcl added a commit to bcl/osbuild that referenced this pull request Aug 4, 2023
They changed their API in 2.11.0 and broke autopep8
See:
hhatto/autopep8#689
and
hhatto/autopep8#696
bcl added a commit to bcl/osbuild that referenced this pull request Aug 7, 2023
They changed their API in 2.11.0 and broke autopep8
See:
hhatto/autopep8#689
and
hhatto/autopep8#696
supakeen pushed a commit to bcl/osbuild that referenced this pull request Aug 8, 2023
They changed their API in 2.11.0 and broke autopep8
See:
hhatto/autopep8#689
and
hhatto/autopep8#696
bcl added a commit to bcl/pykickstart that referenced this pull request Aug 8, 2023
Add it to tox.ini and pin pycodestyle to 2.10.0 until it has been
updated to fix:
hhatto/autopep8#689 and
hhatto/autopep8#696

Add python-3.12.0-rc.1 to the github workflow, and updated the Ubuntu
runner to version 22.04
bcl added a commit to bcl/pykickstart that referenced this pull request Aug 8, 2023
Add it to tox.ini and pin pycodestyle to 2.10.0 until it has been
updated to fix:
hhatto/autopep8#689 and
hhatto/autopep8#696

Add python-3.12.0-rc.1 to the github workflow

Do not switch to Ubuntu 22.04, it does not have python3.6 available and
we still need to test with it.
bcl added a commit to bcl/pykickstart that referenced this pull request Aug 8, 2023
Add it to tox.ini and pin pycodestyle to 2.10.0 until it has been
updated to fix:
hhatto/autopep8#689 and
hhatto/autopep8#696

Add python-3.12.0-rc.1 to the github workflow

Do not switch to Ubuntu 22.04, it does not have python3.6 available and
we still need to test with it.
bcl added a commit to bcl/osbuild that referenced this pull request Aug 9, 2023
They changed their API in 2.11.0 and broke autopep8
See:
hhatto/autopep8#689
and
hhatto/autopep8#696
supakeen pushed a commit to osbuild/osbuild that referenced this pull request Aug 10, 2023
They changed their API in 2.11.0 and broke autopep8
See:
hhatto/autopep8#689
and
hhatto/autopep8#696
@RmaxTwice
Copy link

We really need this PR merged to avoid issues even with pre commit hooks new installations...

@shaperilio
Copy link

#699, #696, #691, #690 are all the same. I suggest someone look into this comment and push their PR forward with a solution.

@ryanpetrello
Copy link

@hhatto any thoughts or feedback on this? This issue is preventing adoption of the latest autopep8 on a project I maintain 👍

@hhatto hhatto self-requested a review August 25, 2023 10:29
Copy link
Owner

@hhatto hhatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry late reply.
LGTM 👍
We will release a new version within a few days.

@hhatto hhatto merged commit eaaa9ce into hhatto:main Aug 25, 2023
@ryanpetrello
Copy link

@hhatto any chance you'd be willing to release a new version of autopep8 to PyPI?

🙏

(thank you!)

@hhatto
Copy link
Owner

hhatto commented Aug 25, 2023

@ryanpetrello
autopep8 version 2.0.3 has been released 🚀
https://pypi.org/project/autopep8/2.0.3/

@ryanpetrello
Copy link

Thank you @hhatto 🙏

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants