Set publish project directory to .publish #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 3, 2020
|
I'm pretty confused but it looks like this somehow fixes the CI so it's started trying to run ScalaJS compilation tasks that weren't running before. That's why the build is failing. I'll hold off on merging while I investigate. |
|
Aah, cool. I was wondering about that. It is reproducible on my machine but I just assumed it was a problem with the internet. |
It is undefined behavior in sbt to have multiple projects that have the
same path. Both the root and publish projects have were defined to be in
the base directory (file(".")). With older versions of sbt, only the
publish project would appear when running the `projects` command. With
sbt 1.4.0-M2, only root appears when running the `projects` command.
After applying this change, both root and publish appear.
|
I went ahead and just rebased the latest master. |
cb372
added a commit
that referenced
this pull request
Sep 7, 2020
|
Closing as I folded your change into #182 |
|
👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is undefined behavior in sbt to have multiple projects that have the
same path. Both the root and publish projects have were defined to be in
the base directory (file(".")). With older versions of sbt, only the
publish project would appear when running the
projectscommand. Withsbt 1.4.0-M2, only root appears when running the
projectscommand.After applying this change, both root and publish appear.