Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump algebra and atto to versions with scala.js 1.0 releases #181

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

cb372
Copy link
Member

@cb372 cb372 commented Sep 4, 2020

Currently in master sbt athemaJS/update will fail because the specified versions of its algebra and atto dependencies have not been published for Scala.js 1.x.

This was not caught until now because of the problem pointed out in #180: currently sbt's default project is set to publish, not the root project. The publish project does not aggregate the athemaJVM and athemaJS projects, so they are not checked by the CI build.

Questions for someone more familiar with the project (@pepegar? @andyscott?):

  • should the publish project aggregate the athema projects? or are they deliberately excluded?
  • what even is the publish project? I assume it's an aggregate of all the projects we want to publish, but how is it used? could we simplify the build by getting rid of it and setting publish := false on any projects we don't want to publish?

@andyscott
Copy link
Member

andyscott commented Sep 4, 2020

should the publish project aggregate the athema projects? or are they deliberately excluded?

The athema project is just a toy/example, so I don't see any reason to publish it.

what even is the publish project? I assume it's an aggregate of all the projects we want to publish, but how is it used? could we simplify the build by getting rid of it and setting publish := false on any projects we don't want to publish?

I don't remember, to be honest! I think I created it as a way to deal with the crazy matrix of incompatibilities across Scala versions and library versions. It may very well be the case that we no longer need the publish project.

@andyscott andyscott merged commit d4cc01c into master Sep 4, 2020
@andyscott andyscott deleted the update-athema-deps branch September 4, 2020 18:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants