Bump algebra and atto to versions with scala.js 1.0 releases #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in master
sbt athemaJS/update
will fail because the specified versions of itsalgebra
andatto
dependencies have not been published for Scala.js 1.x.This was not caught until now because of the problem pointed out in #180: currently sbt's default project is set to
publish
, not the root project. Thepublish
project does not aggregate theathemaJVM
andathemaJS
projects, so they are not checked by the CI build.Questions for someone more familiar with the project (@pepegar? @andyscott?):
publish
project aggregate the athema projects? or are they deliberately excluded?publish
project? I assume it's an aggregate of all the projects we want to publish, but how is it used? could we simplify the build by getting rid of it and settingpublish := false
on any projects we don't want to publish?