-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Match the upstream alt id of the new Levoit air purifier #135426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @markperdue, @webdjoe, @TheGardenMonkey, @cdnninja, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@jiriappl thanks for this. Could you mark ready for review? |
1 similar comment
@jiriappl thanks for this. Could you mark ready for review? |
Proposed change
To support the new C302S Levoit air purifier, upstream pyvesync added support 2 years ago: webdjoe/pyvesync@7888ee7. Alas, the extension needs to mirror the decoding of the model id to the alt id. This change is adding the matching decoding, following the pattern for the other air purifiers.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: