Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade volvooncall to 0.9.2 #64942

Closed
wants to merge 2 commits into from
Closed

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Jan 25, 2022

Proposed change

Upgrade volvooncall to 0.9.2. The update mainly addresses a dependency conflict with websockets.

Release notes: https://github.com/molobrakos/volvooncall/releases/tag/v0.9.2
Compare view: molobrakos/volvooncall@v0.9.1...v0.9.2

The update resolves the following HA dependency conflict

volvooncall 0.9.1 has requirement websockets<=8.1, but you have websockets 10.1.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @molobrakos, @decompil3d, mind taking a look at this pull request as it has been labeled with an integration (volvooncall) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Contributor

@decompil3d decompil3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The volvooncall package update from 0.9.1 to 0.9.2 just updates the MQTT package being used and thus allows for later versions of websockets. Since this integration does not use the MQTT support at all, it should be safe to pull in this new version.

@cdce8p cdce8p mentioned this pull request Jan 25, 2022
22 tasks
@cdce8p cdce8p marked this pull request as draft January 25, 2022 23:39
@cdce8p
Copy link
Member Author

cdce8p commented Jan 26, 2022

Unfortunately, it looks like amqtt introduces two new dependency conflicts.

amqtt 0.10.0 has requirement PyYAML<6.0.0,>=5.4.0, but you have pyyaml 6.0.
amqtt 0.10.0 has requirement websockets<10.0,>=9.0, but you have websockets 10.1.

Both are only requirement conflicts, no code changes should be necessary for amqtt. I've opened issues for them. However, I would still recommend to wait for them before merging this one.

@cdce8p cdce8p added the waiting-for-upstream We're waiting for a change upstream label Jan 26, 2022
@cdce8p
Copy link
Member Author

cdce8p commented Jan 29, 2022

Closing this for now. The dependency conflicts should be resolved before we can merge it.

@cdce8p cdce8p closed this Jan 29, 2022
@cdce8p cdce8p deleted the dep-volvooncall branch January 29, 2022 12:32
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla-signed dependency integration: volvooncall small-pr PRs with less than 30 lines. waiting-for-upstream We're waiting for a change upstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants