Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix localhost.test.js #895

Closed
KernelDeimos opened this issue Sep 30, 2024 · 3 comments · Fixed by #896
Closed

Fix localhost.test.js #895

KernelDeimos opened this issue Sep 30, 2024 · 3 comments · Fixed by #896
Assignees
@n00nchi

Comments

@KernelDeimos
Copy link
Contributor

KernelDeimos commented Sep 30, 2024 •
edited
Loading

The test localhost.test.js is failing with a 404 response when the host address is ::1 rather than localhost or 127.0.0.1. #830 adds support for :: as the permissive listening address so we should fix this to be consistent.
@n00nchi
Copy link

n00nchi commented Oct 1, 2024

Can I pick this up?

@KernelDeimos
Copy link
Contributor Author

Can I pick this up?

Absolutely! I've marked you as assigned.

n00nchi pushed a commit to n00nchi/http-server that referenced this issue Oct 2, 2024
Fix issue http-party#895: Handle requests to ::1 in localhost test - …
03a2c59 
…6 of 6 test pass
@n00nchi n00nchi mentioned this issue Oct 2, 2024
Merged
8 tasks
@n00nchi
Copy link

n00nchi commented Oct 2, 2024

PR: #896

Review when you get the chance. Thank you!

KernelDeimos pushed a commit that referenced this issue Oct 7, 2024
@KernelDeimos
Fix issue #895: Handle requests to ::1 in localhost test - 6 of 6 tes…
165d05e 
…t pass
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@n00nchi n00nchi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #895: Handle requests to ::1 in localhost test - 6 of 6 tes… n00nchi/http-server
2 participants
@KernelDeimos @n00nchi