Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

set default listener on ipv4 and ipv6 interfaces #830

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

ssrahul96
Copy link
Contributor

Relevant issues
Contributor checklist
  • Provide tests for the changes (unless documentation-only)
  • Documented any new features, CLI switches, etc. (if applicable)
    • Server --help output
    • README.md
    • doc/http-server.1 (use the same format as other entries)
  • The pull request is being made against the master branch
Maintainer checklist
  • Assign a version triage tag
  • Approve tests if applicable

Ref : https://www.grouparoo.com/blog/node-js-and-ipv6

@github-actions
Copy link

This pull request has been inactive for 360 days

Copy link
Collaborator

@indexzero indexzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 this appears to be the most permissive address that supports both IPv4 & IPv6. That said, we should add test/localhost.test.js that validates we can connect from:

127.0.0.1
localhost
::1

@KernelDeimos
Copy link
Contributor

Test for this added: b7c46ac

merging this now

@KernelDeimos KernelDeimos merged commit a07121a into http-party:master Sep 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants