Skip to content
This repository has been archived by the owner on Dec 26, 2024. It is now read-only.

[Document] Wrote a document for FAB. #141

Merged
merged 2 commits into from
Oct 6, 2021

Conversation

Juyeong-Byeon
Copy link
Contributor

Description

I wrote a document for FAB.
I explained the definition of FAB and interface.

스크린샷 2021-10-06 오후 11 45 47

Test Plan

none

Related Issues

Related Issues

Tests

none

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Run yarn test:all and make sure nothing fails. You can run yarn test -u to update snapshots if needed.
  • I am willing to follow-up on review comments in a timely manner.

1. add story for FAB button in doc project
2. add basic introduction  doc for FAB
@Juyeong-Byeon Juyeong-Byeon mentioned this pull request Oct 6, 2021
3 tasks
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #141 (770edcd) into master (8c40090) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files          27       27           
  Lines         648      648           
  Branches      283      283           
=======================================
  Hits          613      613           
  Misses         34       34           
  Partials        1        1           

add Demo
@Juyeong-Byeon
Copy link
Contributor Author

@hyochan @yujong-lee
I wrote a document for FAB.
check plz.

@yujonglee yujonglee self-requested a review October 6, 2021 18:11
@yujonglee yujonglee added the 📖 documentation Improvements or additions to documentation label Oct 6, 2021
Copy link
Contributor

@yujonglee yujonglee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍

@yujonglee yujonglee closed this Oct 6, 2021
@yujonglee yujonglee reopened this Oct 6, 2021
@yujonglee yujonglee merged commit 8d0de13 into hyochan:master Oct 6, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
📖 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants