Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Abstract test case input output lists in unit tests #463

Closed
dhblum opened this issue Aug 3, 2022 · 4 comments · Fixed by #472
Closed

Abstract test case input output lists in unit tests #463

dhblum opened this issue Aug 3, 2022 · 4 comments · Fixed by #472
Assignees
Milestone

Comments

@dhblum
Copy link
Collaborator

dhblum commented Aug 3, 2022

This is to abstract the definition of input and output lists within if-else statements in the API unit tests in utilities.py to the setUp method in each test cases's specific testing file test_<testcase>. For example in these locations:

@dhblum
Copy link
Collaborator Author

dhblum commented Aug 3, 2022

Assign @EttoreZ.

@EttoreZ
Copy link
Contributor

EttoreZ commented Aug 4, 2022

I will make a pull request on the branch Issue463_abstract_testcase_inout_lists_unittests. @dhblum could you create that branch for me on the IBPSA repo?

@EttoreZ
Copy link
Contributor

EttoreZ commented Aug 9, 2022

I made the pull request, I only have one comment:
In the script utilities.py function test_advance_false_overwrite, the input used for bestest_hydronic is different than in function test_invalid_advance_value, namely u = {'oveTSetSup_activate': 0, 'oveTSetSup_u': 273.15+60, 'ovePum_activate': 0,'ovePum_u': 1} and u = {'oveTSetSup_activate': 0, 'oveTSetSup_u': 273.15+60,'ovePum_activate': 0}. In the pull request I used the first input dictionary and running the tests passed all of them, since the actual values or number of inputs do not matter for those specific unit test.

@dhblum
Copy link
Collaborator Author

dhblum commented Aug 11, 2022

Closed by #472.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants