Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Issue463 abstract test case tests #471

Conversation

EttoreZ
Copy link
Contributor

@EttoreZ EttoreZ commented Aug 9, 2022

This pull request is to address issue #463.

EttoreZ added 6 commits March 17, 2022 12:56
updating local master branch
Update local master branch with latest master
Update issue463 with latest master version
Copy link
Collaborator

@dhblum dhblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EttoreZ Thanks for this PR. Please address the one inline comment and then I think this will be ready to go.

@EttoreZ
Copy link
Contributor Author

EttoreZ commented Aug 10, 2022

Thank you @dhblum for the careful review. I added the comment #<u_variable>_activate is meant to be 0 for the test_advance_false_overwrite API test above the self.input definition and updated the pull request.

Copy link
Collaborator

@dhblum dhblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EttoreZ for the udpates.

@dhblum dhblum merged commit 3d124aa into ibpsa:issue463_abstractTestCaseTests Aug 10, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants