Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Issue465 multizone office simple hydronic finalize #619

Merged
merged 121 commits into from
Aug 28, 2024

Conversation

dhblum
Copy link
Collaborator

@dhblum dhblum commented Feb 8, 2024

This is for #465 and #675 and will add the multizone_office_simple_hydronic test case. It follows PRs #618 and #469. This version of the model compiles with Modelon's OPTIMICA Compiler Toolkit (OCT) as described in this comment.

Remaining ToDos:

  • Unit test configuration and reference results update
  • Test updates to coil dTs and update unit test ref results
  • Documentation edits in index.html, including new I/O descriptions and floor plan figure
  • Transfer doc edits from index.html to .mo.
  • Update release notes
  • Update contributors
  • Final reviews
  • Make note on requirement to run in Dymola (and compare results)
  • Fix heating production power to electricity instead of gas for KPI tag
  • Adjust typical and peak heating and cooling days as needed
  • Update reference results
  • Remove BuildingEmulators_BuildingSystem.fmu
  • Submit final wrapped fmu
  • Pass unit tests

Iago Cupeiro Figueroa and others added 30 commits August 7, 2022 13:28
…m:icupeiro/project1-boptest into issue465_multizone_office_simple_hydronic
@dhblum
Copy link
Collaborator Author

dhblum commented Apr 12, 2024

No problem @icupeiro thanks. Good luck with everything.

dhblum and others added 4 commits July 15, 2024 10:28
…reset trigger in Ahu internal control 2. Avoid preconditioning at full throttle on both sides 3. Changed AHU parameter from entering to leaving
@dhblum
Copy link
Collaborator Author

dhblum commented Aug 5, 2024

Simulated for one year with OCT 1.51.6 py3.9 and Dymola 2024x Refresh 1, both on Ubuntu 20.04. Results agreed (heating_cooling.reaPProHea.y, heating_cooling.reaPProCoo.y, structure.reaTZonNz.y, and structure.reaTZonSz.y). To run in Dymola, needed to change in BuildingEmulators.Components.IdealProduction (consistent with #465 (comment)):

     connect(TSet,TSetIn);
     if not use_TSet then
         TSet = 0;

to

    TSet=TSetIn;
    if not use_TSet then
        TSet = 0;
    end if;

@dhblum dhblum merged commit 1e37f71 into master Aug 28, 2024
@dhblum dhblum deleted the issue465_multizone_office_simple_hydronic branch August 28, 2024 19:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants