-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Additional flow space features #1
Conversation
the read base calls or the reference homopolymer length.
Signed-off-by: Nils Homer <nilshomer@gmail.com> Signed-off-by: Nils Homer <nils.homer@lifetech.com>
Signed-off-by: Nils Homer <nilshomer@gmail.com> Signed-off-by: Nils Homer <nils.homer@lifetech.com>
Signed-off-by: Nils Homer <nils.homer@lifetech.com>
Some of this has already been discussed via email, but I'll restate. In general we want to accept this but not yet.
Re: 3., why JSON for copying to clipboard? Could you post an example of what a typical string would look like? I'll leave this request open for now, feel free to update the branch (or if you'd like to close it that's fine too). |
I will keep my fork update until you ready to start work on the new context menu, as well as ready to discuss on-demand options. Re:3, JSON is a very convenient and readable format for this type of data. We could make this a preference too! A dummy example would be: |
I'm a huge fan of JSON when the other option is XML, I'm just wondering if it will include extra characters that we don't really need. Most of our copy-to-clipboard is basically a table format, so in your example it might be: 198 : 12 I don't quite know what the use case for this is; are you grabbing small snippets to put in a text file and eyeball, or are people going to be making big data files and looking at them in excel? You're the user, so you know better than I do. |
I think from IGV, folks may look at them in excel, R, or whatever language they choose. Sure we have extra characters, but that's JSON. |
Well I'll defer to you for now. But if anybody else complains it's on you ;-). |
I'll just add a dropdown list in the preferences bar... |
Any news on the switch over to this GIT repository, and when I should start developing on the new UI? |
Conflicts: src/org/broad/igv/sam/AlignmentTrack.java src/org/broad/igv/sam/SamAlignment.java src/org/broad/igv/ui/PreferencesEditor.java
Talking to other devs, may happen soon. You don't have to wait for the switch, we can always copy changes in via patch. Is the functionality the same as in the original pull request, or have you added more? GitHub is saying this branch can't be auto-merged (likely my fault, small mistakes when using git svn can force one to rewrite the git history on push). Don't worry about that now because we may not try to do a git merge for this patch anyway, just thought I'd let you know. |
…aster.bk Conflicts: src/org/broad/igv/ui/PreferencesEditor.java
Additional flow space features
I have added additional features:
commit fa6c3bc