WIP(iox-10577): patched df upgrade 202-04-05 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…che#9897) * Revert "use alias (apache#9894)" This reverts commit 9487ca0. * Use `struct` instead of `named_struct` when there are no aliases * Update docs * fmt
…pache#9958) * for debug finish remove print add space * fix clippy * finish * fix clippy
…/update-df-apr-week-1-2
…/update-df-apr-week-1-2
…/update-df-apr-week-1-2
…/update-df-apr-week-1-2
…/update-df-apr-week-1-2
…/update-df-apr-week-1-2
appletreeisyellow
changed the title
|
The upgrade is done. Closing |
appletreeisyellow
added a commit
that referenced
this pull request
May 24, 2024
…he#10527) * chore: merge main and resolve conflict * chore: use less copy * chore: remove clone * remove more clones (#8) * refactor: use HashSet<&Expr> instead of HashSet<String> * refactor: remove more cloning * chore: reduce string allocation Co-authored-by: Adam Curtis <adam.curtis.dev@gmail.com> * chore: return internal error instead of panacing * chore: use arg display_name as hash key instead of a hashed value --------- Co-authored-by: Adam Curtis <adam.curtis.dev@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #5 that including the following patches:
Bringing us up to datafusion to 2024-04-05
PATCH: add the named struct patch
PATCH: include the patch request (per slack) for the upstream coalesce bug.
apache@4d85979 / coercion vec[Dictionary, Utf8] to Dictionary for coalesce function apache/datafusion#9958
PATCH: patch for the function re-writer, visiting subqueries within expressions.