fix: Multi-org dropdown shouldn't show typeahead if only one account/org #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion if only one org or acct
wdoconnell
requested review from
a team,
mavarius,
brandenTenbrink and
juliajames12
as code owners
ChitlangeSahas
approved these changes
Jul 1, 2022
5 tasks
This reverts commit 3e3d3a1.
wdoconnell
changed the title
| selected={value.id === selectedItem?.id} | ||
| /* Values need to be compared as string because account items have number ids*/ | ||
| selected={ | ||
| value.id.toString() === selectedItem?.id.toString() |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per UI 4047 and UI 4051, the multi-org dropdown:
idafter converting to a string: Org arrays havestringids, but account arrays havenumberids.EDIT: Removed prior change involving sorting selected item to first part of the array. That is easier to handle in a sort in the UI.
Checklist
Check all that apply