Skip to content

Refactor useless .ContinueWith in Api to direct call #108

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
bednar opened this issue Jul 3, 2020 · 0 comments · Fixed by #110
Closed

Refactor useless .ContinueWith in Api to direct call #108

bednar opened this issue Jul 3, 2020 · 0 comments · Fixed by #110
Assignees
@rolincova
Labels
bug Something isn't working
Milestone
1.10.0

Comments

@bednar
Copy link
Contributor

bednar commented Jul 3, 2020 

await _service.GetLabelsAsync().ContinueWith(t => t.Result.Labels);

could be refactored to

(await _service.GetLabelsAsync()).Labels;

Screenshot 2020-07-03 at 08 23 52
@bednar bednar added the enhancement New feature or request label Jul 3, 2020
@bednar bednar mentioned this issue Jul 3, 2020
Merged
rolincova added a commit that referenced this issue Jul 14, 2020
@rolincova
refactor: Replaced useless .ContinueWith in Api by direct call (#108)
c101fbd
@rolincova rolincova mentioned this issue Jul 14, 2020
Merged
4 tasks
rolincova added a commit that referenced this issue Jul 15, 2020
@rolincova
refactor: Replaced useless .ContinueWith in Api by direct call (#108)
9966849
bednar pushed a commit that referenced this issue Jul 15, 2020
@rolincova
fix: Replaced useless .ContinueWith in Api by direct call (#108) (#110)
c35c505
@bednar bednar added bug Something isn't working and removed enhancement New feature or request labels Jul 15, 2020
@bednar bednar added this to the 1.10.0 milestone Jul 15, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@rolincova rolincova

Labels
bug Something isn't working
Projects
None yet
Milestone
1.10.0
Development

Successfully merging a pull request may close this issue.

fix: Replaced useless .ContinueWith in Api by direct call (#108) influxdata/influxdb-client-csharp
2 participants
@bednar @rolincova