feat: improve WriteApi performance #97
Conversation
|
Hi @bnayae, could you please rebase the PR to avoid conflicts? |
|
can you send the rebase command (and i will run it)? |
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
- Coverage 15.67% 15.65% -0.03%
==========================================
Files 50 50
Lines 4989 4996 +7
Branches 252 252
==========================================
Hits 782 782
- Misses 4187 4194 +7
Partials 20 20
Continue to review full report at Codecov.
|
Client/OrganizationsApi.cs
Outdated
| public async Task<List<Organization>> FindOrganizationsAsync() | ||
| public Task<List<Organization>> FindOrganizationsAsync() | ||
| { | ||
| return await _service.GetOrgsAsync().ContinueWith(t => t.Result.Orgs); | ||
| return _service.GetOrgsAsync().ContinueWith(t => t.Result.Orgs); |
There was a problem hiding this comment.
Why are async and await removed?
public async Task<List<Organization>> FindOrganizationsAsync()
{
return await _service.GetOrgsAsync().ContinueWith(t => t.Result.Orgs);
}There was a problem hiding this comment.
I thought you asked for it
There was a problem hiding this comment.
Sorry for late. We've fixed the useless ContinueWith in #108. Could you rebase sources with master branch?
There was a problem hiding this comment.
I don't sure how to rebase it, i already push it to the fork.
I can merge and remove this issue
Some refactoring to the WriteApi which aimed to
having more performance & simplify the code.
This is a join effort of @weknow-network & @AviAvni.
We intend to provide better simplification of the code & better performance by converting the RX channel to TPL Dataflow or System.Threading.Channels.
We will provide this changes on separate Pull Request based on this PR.
We will maintain the RX pipeline as optional strategy until you'll decide to remove it.