Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Review tosprey documentation before release #204

Closed
donyunardi opened this issue May 25, 2023 · 0 comments · Fixed by #216
Closed

Review tosprey documentation before release #204

donyunardi opened this issue May 25, 2023 · 0 comments · Fixed by #216
Assignees
@m7pr
Labels
core

Comments

@donyunardi
Copy link
Contributor

donyunardi commented May 25, 2023 •
edited by m7pr
Loading

Summary

Related with insightsengineering/nestdevs-tasks#25
In preparation to release, we need to review/assess all documentation in the package.

Acceptance Criteria

  • Review roxygen examples on all functions
    • Test examples
    • If it's using chunk, update to qenv.
  • Review vignettes on these topics only:
    • Review any content around qenv
    • Review any content around chunks (i.e. make sure the right language around deprecation)
    • Review any content around shinyvalidate
  • redo the content of WORDLIST
  • Update NEWS
  • Update README (if applicable)
  • Review DESCRIPTION file (i.e check dependency versions, etc)
    • Be sure to update teal.code dependency to be >= 0.3.0
This was referenced May 25, 2023
Closed
Closed
Closed
@gogonzo gogonzo self-assigned this Jun 30, 2023
This was referenced Jun 30, 2023
Merged
Merged
@gogonzo gogonzo removed their assignment Jun 30, 2023
gogonzo added a commit that referenced this issue Jul 6, 2023
@gogonzo
Decouple scda (#214)
b6de623 
closes #213
#204


see also:
- insightsengineering/scda#125
- insightsengineering/scda.2022#123
@chlebowa chlebowa assigned chlebowa and unassigned chlebowa Jul 6, 2023
@m7pr m7pr self-assigned this Jul 12, 2023
m7pr added a commit that referenced this issue Jul 13, 2023
@m7pr
fix #204
35e8092
@m7pr m7pr mentioned this issue Jul 13, 2023
Merged
@m7pr m7pr closed this as completed in #216 Jul 13, 2023
m7pr added a commit that referenced this issue Jul 13, 2023
@m7pr
214 review documentation after chunks->qenv transition (#216)
fc77915 
This closes #204 

@gogonzo there is one example that fails - #215 - besides that they all
run fine. There is no `teal.code::chunks` narration exposed in examples
nor vignettes. Also the `teal.code` was already at 0.3.0 so no need to
update DESCRIPTION file. I don't think I am able to resolve #215 even
though I tried a couple of times.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@m7pr m7pr

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

214 review documentation after chunks->qenv transition insightsengineering/teal.osprey
4 participants
@gogonzo @donyunardi @chlebowa @m7pr