Skip to content

[UR] Consolidate platform and adapter backend enums into one. #16173

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 24, 2025
Merged

[UR] Consolidate platform and adapter backend enums into one. #16173

merged 10 commits into from
Mar 24, 2025

Conversation

aarongreig
Copy link
Contributor

@aarongreig aarongreig commented Nov 25, 2024 •
edited
Loading

UR changes ported from oneapi-src/unified-runtime#2377

@aarongreig aarongreig mentioned this pull request Nov 25, 2024
Closed
@aarongreig aarongreig marked this pull request as ready for review February 4, 2025 15:41
@aarongreig aarongreig requested review from a team as code owners February 4, 2025 15:41
@aarongreig
Copy link
Contributor Author

ping @intel/llvm-reviewers-runtime

@aarongreig aarongreig requested review from a team as code owners February 24, 2025 11:45
@aarongreig aarongreig force-pushed the aaron/mergeAdapterPlatformBackend branch from aea1f8e to eb70dfb Compare February 24, 2025 11:49
@aarongreig
Copy link
Contributor Author

ping @intel/unified-runtime-reviewers @intel/dpcpp-nativecpu-reviewers @intel/llvm-reviewers-cuda UR changes were previously approved on oneapi-src/unified-runtime#2377

@aarongreig
Copy link
Contributor Author

@intel/llvm-gatekeepers please merge

@martygrant martygrant merged commit 7515943 into intel:sycl Mar 24, 2025
30 checks passed
@ayylol
Copy link
Contributor

ayylol commented Mar 24, 2025

@aarongreig this seems to have caused some regressions when building the compiler.

aelovikov-intel added a commit that referenced this pull request Mar 24, 2025
@aelovikov-intel
Revert "[UR] Consolidate platform and adapter backend enums into one. (…
26abdba 
…#16173)"

This reverts commit 7515943.
@aelovikov-intel aelovikov-intel mentioned this pull request Mar 24, 2025
Merged
aelovikov-intel added a commit that referenced this pull request Mar 24, 2025
@aelovikov-intel
Revert "[UR] Consolidate platform and adapter backend enums into one." (
0886791 
#17604)

Reverts #16173
@aarongreig
Copy link
Contributor Author

fix for post-merge build issue #17603

@aarongreig aarongreig mentioned this pull request Mar 24, 2025
Merged
RossBrunton pushed a commit to oneapi-src/unified-runtime that referenced this pull request Mar 24, 2025
@aelovikov-intel @RossBrunton
Revert "[UR] Consolidate platform and adapter backend enums into one.…
3c2be30 
…" (#17604)

Reverts intel/llvm#16173
kbenzie pushed a commit that referenced this pull request May 14, 2025
@aarongreig
[UR] Consolidate platform and adapter backend enums into one. (#17605)
bb5a475 
second attempt to land #16173
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@frasercrmck frasercrmck frasercrmck approved these changes

@hvdijk hvdijk hvdijk approved these changes

@kbenzie kbenzie kbenzie approved these changes

@fabiomestre fabiomestre fabiomestre approved these changes

@Seanst98 Seanst98 Seanst98 approved these changes

@uditagarwal97 uditagarwal97 uditagarwal97 approved these changes

@cperkinsintel cperkinsintel Awaiting requested review from cperkinsintel cperkinsintel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@aarongreig @ayylol @frasercrmck @hvdijk @kbenzie @fabiomestre @Seanst98 @uditagarwal97 @martygrant