Skip to content

[UR] Consolidate platform and adapter backend enums into one. #17605

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
May 14, 2025

Conversation

aarongreig
Copy link
Contributor

@aarongreig aarongreig commented Mar 24, 2025

second attempt to land #16173

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It looks like a NFC to me, is that right?

@aarongreig
Copy link
Contributor Author

yeah I guess it kind of is, although as we've seen it does break other changes that use the affected enums

@aarongreig aarongreig requested review from a team as code owners April 4, 2025 13:11
@aarongreig
Copy link
Contributor Author

aarongreig commented Apr 4, 2025

ping @intel/dpcpp-nativecpu-reviewers note this is not a new patch, it's an attempt to re-land with a minor fix

Copy link
Contributor

@hvdijk hvdijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NativeCPU changes are identical to the earlier attempt so still look fine, thanks.

Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for L0

@aarongreig aarongreig removed the request for review from frasercrmck May 13, 2025 15:40
@aarongreig
Copy link
Contributor Author

arc fails due to #18416

@intel/llvm-gatekeepers please merge

@kbenzie kbenzie merged commit bb5a475 into intel:sycl May 14, 2025
32 of 33 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants