Skip to content

Re-land "Promote SPV_INTEL_optimization_hints to SPV_KHR_expect_assume" #3960

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2021
Merged

Re-land "Promote SPV_INTEL_optimization_hints to SPV_KHR_expect_assume" #3960

merged 2 commits into from
Oct 28, 2021

Conversation

MrSidims
Copy link
Contributor

No description provided.

@MrSidims
Copy link
Contributor Author

/summary:run

@MrSidims MrSidims force-pushed the private/MrSidims/AssumeExpect branch from 074cec7 to 18a26c4 Compare June 21, 2021 13:00
@MrSidims MrSidims marked this pull request as draft June 21, 2021 13:03
@MrSidims
Copy link
Contributor Author

InvalidModule: Invalid SPIR-V module: input SPIR-V module uses unknown extension 'SPV_KHR_expect_assume'

Waiting for a CPU RT update, ZzZzzzz.

@AGindinson
Copy link
Contributor

Waiting for a CPU RT update, ZzZzzzz.

It's been promoted as #3946.

@AlexeySachkov
Copy link
Contributor

Waiting for a CPU RT update, ZzZzzzz.

It's been promoted as #3946.

And we need one more promotion

@AlexeySotkin
Copy link
Contributor

AlexeySotkin commented Oct 26, 2021 •
edited
Loading

Waiting for a CPU RT update, ZzZzzzz.

It's been promoted as #3946.

And we need one more promotion

We had a promotion few weeks ago - #4671. @MrSidims, @AlexeySachkov can we merge it now?

@MrSidims
Re-land "Promote SPV_INTEL_optimization_hints to SPV_KHR_expect_assume"
990a1e0 
This reverts commit 733c4fc.

Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
@MrSidims MrSidims force-pushed the private/MrSidims/AssumeExpect branch from 18a26c4 to ce84a3d Compare October 26, 2021 09:35
@MrSidims MrSidims marked this pull request as ready for review October 26, 2021 09:35
@MrSidims MrSidims requested a review from hchilama as a code owner October 26, 2021 09:35
@MrSidims
Copy link
Contributor Author

/summary:run

@MrSidims
Replace SPV_INTEL_optimization_hints with SPV_KHR_expect_assume
8efe9d2 
Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
@MrSidims MrSidims force-pushed the private/MrSidims/AssumeExpect branch from ce84a3d to 8efe9d2 Compare October 26, 2021 14:05
@MrSidims
Copy link
Contributor Author

/summary:run

@MrSidims
Copy link
Contributor Author

@AlexeySotkin yes, after the approval.
@AGindinson @mdtoguchi @hchilama could you please review from the driver perspective?
@AlexeySotkin @AlexeySachkov could you please review from the translator perspective?

AlexeySotkin
AlexeySotkin approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@AlexeySotkin AlexeySotkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPIR-V part looks good to me. It is aligned with KhronosGroup/SPIRV-LLVM-Translator#991

@MrSidims
Copy link
Contributor Author

@hchilama @mdtoguchi @AGindinson friendly ping to review LLVM Driver - related changes

@bader bader merged commit 696ac39 into intel:sycl Oct 28, 2021
@MrSidims MrSidims mentioned this pull request Oct 28, 2021
Closed
@vmaksimo vmaksimo mentioned this pull request Nov 1, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@AlexeySotkin AlexeySotkin AlexeySotkin approved these changes

@AGindinson AGindinson AGindinson approved these changes

@AlexeySachkov AlexeySachkov Awaiting requested review from AlexeySachkov

@mdtoguchi mdtoguchi Awaiting requested review from mdtoguchi

@hchilama hchilama Awaiting requested review from hchilama

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MrSidims @AGindinson @AlexeySachkov @AlexeySotkin @bader