JSON.parse error reporting: with invalid json: in the error string

[KrishnaPG]

Better error reporting in case of json.parse failures

resolves #912
resolves #1000

[hugomrdias]

@alanshaw this is only failing on commitlint should be good to merge

[alanshaw]

I think @KrishnaPG is going to update this to be even better ;)

#1000 (comment)

[alanshaw]

Almost there - just some minor tweaks and this'll be good. Would love to see some tests for this!?

[KrishnaPG]

The remaining lint error is about handling the error in callback

/home/travis/build/ipfs/js-ipfs-http-client/src/utils/send-request.js
   25:31  error    Expected error to be handled  handle-callback-err

By design we are ignoring that error, since we are already inside an error handler (with a valid error response from server).

Is there a way to turn this lint error off, for this specific case, so that this can be merged?

[KrishnaPG]

The changes in this PR now enables usage such as:

ipfs.block.put(Buffer.from("Hello " + Date()), (err, block) => {
  if (err) {
     if (err.code == 401 || err.code == 403) 
        return Retry_With_Auth(block); // retry this whole thing with renewed AUTH Headers somehow
     // else some really problematic error
  }
  // success
})

Earlier this was not possible, since the textual response from gateways was crashing the app.

[alanshaw]

@KrishnaPG I've rebased, added tests and changed code to statusCode (since it conflicts with the code in the JSON response) here: #1016