This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: error reporting for non-JSON responses #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better error reporting in case of `json.parse` failures
Making the `parseError` function compatible with non-JSON responses from server. - `isJson = true` parameter added that is backwards compatible with existing code Ref: #1000 (comment)
`parseError` method should print default error in case data is null or empty ("")
Co-Authored-By: Alan Shaw <alan.shaw@protocol.ai>
This makes `parseError` more self-sufficient.
35:1 error Trailing spaces not allowed no-trailing-spaces
This is needed for the callers to know when the error needs a retry (such as 401, 403 etc.
Uses `statusCode` since `code` is being used in JSON responses. License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
|
PR build is failing because of commit lint in earlier commits. Branch build is passing. Lets get this merged! Thanks again @KrishnaPG |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better error reporting by detecting
Content-Typeof the response and not attempting to parse JSON for non-application/jsonresponses.resolves #912
resolves #1000
closes #1001