Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

Fix schema for Tuple, Dict #194

Closed
madhur-tandon opened this issue Apr 13, 2022 · 0 comments · Fixed by #246
Closed

Fix schema for Tuple, Dict #194

madhur-tandon opened this issue Apr 13, 2022 · 0 comments · Fixed by #246
Labels
bug Something isn't working

Comments

@madhur-tandon
Copy link
Contributor

madhur-tandon commented Apr 13, 2022 •
edited
Loading

.get_model().schema() fails for Tuple and Dict with KeyError: <class 'pydantic.main.Primitive'>
@madhur-tandon madhur-tandon changed the title Fix schema for NumpyNumber and Primitive Fix schema for Tuple, Dict Apr 13, 2022
@omesser omesser added the bug Something isn't working label Apr 13, 2022
mike0sv added a commit that referenced this issue May 12, 2022
@mike0sv
add prefix for model names
6399e65 
simplify models for primitives
closes #194
@mike0sv mike0sv mentioned this issue May 12, 2022
Merged
madhur-tandon pushed a commit that referenced this issue May 16, 2022
@mike0sv @madhur-tandon
add prefix for model names
3d18a5b 
simplify models for primitives
closes #194
madhur-tandon added a commit that referenced this issue May 16, 2022
@mike0sv @madhur-tandon
add prefix for model names (#246)
a4a4bba 
* add prefix for model names
simplify models for primitives
closes #194

* resolve conflicts + add schema for tuple and dict

Co-authored-by: Madhur Tandon <madhurtandon23@gmail.com>
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add prefix for model names iterative/mlem
2 participants
@omesser @madhur-tandon