Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

add prefix for model names #246

Merged
merged 2 commits into from
May 16, 2022
Merged

add prefix for model names #246

merged 2 commits into from
May 16, 2022

Conversation

mike0sv
Copy link
Contributor

@mike0sv mike0sv commented May 12, 2022

simplify models for primitives
closes #194

@mike0sv mike0sv requested review from madhur-tandon and a team May 12, 2022 12:00
@mike0sv mike0sv self-assigned this May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #246 (97c6cf3) into main (00b0162) will increase coverage by 0.04%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   89.55%   89.59%   +0.04%     
==========================================
  Files          76       76              
  Lines        5449     5451       +2     
==========================================
+ Hits         4880     4884       +4     
+ Misses        569      567       -2     
Impacted Files Coverage Δ
mlem/contrib/pandas.py 92.35% <75.00%> (ø)
mlem/contrib/lightgbm.py 94.50% <100.00%> (ø)
mlem/contrib/numpy.py 98.29% <100.00%> (ø)
mlem/contrib/torch.py 98.79% <100.00%> (ø)
mlem/contrib/xgboost.py 97.56% <100.00%> (ø)
mlem/core/dataset_type.py 95.83% <100.00%> (+0.03%) ⬆️
mlem/contrib/heroku/meta.py 86.11% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00b0162...97c6cf3. Read the comment docs.

@aguschin
Copy link
Contributor

Should we merge this? @mike0sv

@madhur-tandon
Copy link
Contributor

@aguschin I am gonna resolve some conflicts + add some tests. We can merge it then. My Github token expired, fixing that right now

@madhur-tandon madhur-tandon merged commit a4a4bba into main May 16, 2022
@madhur-tandon madhur-tandon deleted the fix/schema-errors branch May 16, 2022 09:38
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fix schema for Tuple, Dict
3 participants