Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

Fix mlem clone with DVC-tracked binaries in private repos #596

Closed
wants to merge 4 commits into from
Closed

Fix mlem clone with DVC-tracked binaries in private repos #596

wants to merge 4 commits into from

Conversation

aguschin
Copy link
Contributor

close #528

@aguschin aguschin requested a review from a team January 27, 2023 06:33
@aguschin aguschin self-assigned this Jan 27, 2023
@aguschin aguschin temporarily deployed to internal January 27, 2023 06:33 — with GitHub Actions Inactive
@aguschin
Copy link
Contributor Author

Works on my computer (c)
Can add tests, but for that we need a special private repo. Do you think it worth it? @mike0sv

@aguschin
Copy link
Contributor Author

aguschin commented Jan 27, 2023 •
edited
Loading

ok, I see many errors. I'll see how to fix them
UPD: looks like they're present in another PR as well (at least some of them) #597
so it's probably something else, not the code in this PR

@aguschin aguschin temporarily deployed to internal January 27, 2023 10:47 — with GitHub Actions Inactive
aguschin
aguschin commented Feb 15, 2023
View reviewed changes
@aguschin aguschin temporarily deployed to internal February 15, 2023 07:04 — with GitHub Actions Inactive
@aguschin aguschin temporarily deployed to internal February 15, 2023 07:04 — with GitHub Actions Inactive
@aguschin aguschin mentioned this pull request Feb 15, 2023
Closed
@aguschin aguschin closed this Feb 15, 2023
@aguschin aguschin deleted the fix/dvc-private-repo branch February 15, 2023 09:55
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers
No reviews
Assignees

@aguschin aguschin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't load a model from private repo with binaries stored with DVC
1 participant
@aguschin