This repository was archived by the owner on Sep 13, 2023. It is now read-only.
Print correct cmd to activate venv after mlem build venv
#597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aguschin
commented
Jan 27, 2023
| @@ -14,7 +14,7 @@ | |||
| "aiohttp<4", | |||
| "aiohttp_swagger<2", | |||
| "Jinja2>=3", | |||
| "fsspec>=2021.7.0", | |||
| "fsspec>=2021.7.0,<2023.1", | |||
There was a problem hiding this comment.
to fix errors like https://github.com/iterative/mlem/actions/runs/4022310524/jobs/6911940431
didn't have time to investigate
Codecov ReportBase: 86.42% // Head: 86.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #597 +/- ##
==========================================
+ Coverage 86.42% 86.43% +0.01%
==========================================
Files 106 106
Lines 9567 9589 +22
==========================================
+ Hits 8268 8288 +20
- Misses 1299 1301 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mike0sv
reviewed
Jan 27, 2023
| install_cmd.append("--no-cache-dir") | ||
| install_cmd.extend(obj.requirements.to_pip()) | ||
| run_in_subprocess(install_cmd, error_msg="Error running pip") | ||
| if obj.requirements.to_pip(): |
There was a problem hiding this comment.
maybe create a variable since it's used twice
mike0sv
approved these changes
Jan 27, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #547