Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

Change args for docker build #604

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Change args for docker build #604

merged 3 commits into from
Feb 14, 2023

Conversation

mike0sv
Copy link
Contributor

@mike0sv mike0sv commented Feb 13, 2023

closes #522

@mike0sv mike0sv requested a review from a team February 13, 2023 13:40
@mike0sv mike0sv self-assigned this Feb 13, 2023
@mike0sv mike0sv temporarily deployed to internal February 13, 2023 13:40 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 86.07% // Head: 86.07% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5dcab07) compared to base (0c6f03c).
Patch coverage: 96.55% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #604   +/-   ##
=======================================
  Coverage   86.07%   86.07%           
=======================================
  Files         107      107           
  Lines        9680     9683    +3     
=======================================
+ Hits         8332     8335    +3     
  Misses       1348     1348           
Impacted Files Coverage Δ
mlem/contrib/docker/base.py 85.00% <95.00%> (+0.14%) ⬆️
mlem/contrib/docker/helpers.py 100.00% <100.00%> (ø)
mlem/contrib/kubernetes/build.py 100.00% <100.00%> (ø)
mlem/contrib/sagemaker/build.py 63.38% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mike0sv mike0sv temporarily deployed to internal February 13, 2023 16:00 — with GitHub Actions Inactive
@aguschin
Copy link
Contributor

check this before merging #522 (comment)

@mike0sv mike0sv temporarily deployed to internal February 14, 2023 14:09 — with GitHub Actions Inactive
@mike0sv mike0sv temporarily deployed to internal February 14, 2023 16:39 — with GitHub Actions Inactive
@mike0sv mike0sv merged commit 4c8e1a7 into main Feb 14, 2023
@mike0sv mike0sv deleted the fix/docker-build-args branch February 14, 2023 18:38
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to push image at mlem build to no avail
2 participants