ROS2 Migration #21
Open
ROS2 Migration #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request migrates the ROS1 version of this driver to ROS. The aim was to modify the code as little as possible to maintain compatibility with the existing codebase. Therefore, not all of the modifications are totally in keeping with ROS2 standard practice, rather they emulate ROS1 Behavior with ROS2.
This driver was tested to the best of my knowledge with the included
.pcapfiles and with a physical IxBlue ROVINS nano. It appears fully operational and accurate as far I can tell. I did not fully migrate the automated tests.I also made the pull request to the
masterbranch since that was all that's available. You may want to create aros2orhumble-develbranch to merge this into.If you have an questions or need any changes to the code let me know.
-Kris