Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[embed] Scatter plot links to trace lose embed mode when clicked #282

Closed
tiffon opened this issue Nov 28, 2018 · 4 comments
Closed

[embed] Scatter plot links to trace lose embed mode when clicked #282

tiffon opened this issue Nov 28, 2018 · 4 comments
Labels
bug

Comments

@tiffon
Copy link
Member

tiffon commented Nov 28, 2018

Requirement - what kind of business use case are you trying to solve?

When in embed mode on the search page, clicking a dot from the scatter plot should retain embed mode.

Problem - what in Jaeger blocks you from solving the requirement?

When in embed mode on the search page, clicking a dot from the scatter plot loses retain embed mode, currently.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Retain embed mode when viewing the trace.

Any open questions to address

n/a
@tiffon tiffon added the bug label Nov 28, 2018
@tiffon
Copy link
Member Author

tiffon commented Nov 28, 2018

cc @aljesusg

aljesusg added a commit to aljesusg/jaeger-ui that referenced this issue Nov 28, 2018
@aljesusg
Fix link in scatter plot when embed mode jaegertracing#282
c9d09d5
aljesusg added a commit to aljesusg/jaeger-ui that referenced this issue Nov 28, 2018
@aljesusg
Fix link in scatter plot when embed mode jaegertracing#282
08bc3a0 
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
aljesusg added a commit to aljesusg/jaeger-ui that referenced this issue Nov 28, 2018
@aljesusg
Fix link in scatter plot when embed mode jaegertracing#282
63ea39e 
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
@aljesusg aljesusg mentioned this issue Nov 28, 2018
Merged
aljesusg added a commit to aljesusg/jaeger-ui that referenced this issue Nov 28, 2018
@aljesusg
Fix link in scatter plot when embed mode jaegertracing#282
e1bbe6d 
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
tiffon pushed a commit that referenced this issue Nov 28, 2018
@aljesusg
Fix link in scatter plot when embed mode #282 (#283)
fcd6bfd 
Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
@aljesusg
Copy link
Contributor

We can close this issue ;) Thanks @tiffon

@tiffon
Copy link
Member Author

tiffon commented Nov 28, 2018

Right. 👍

If you add Fixes #N. to the PR it will close automatically.

@tiffon tiffon closed this as completed Nov 28, 2018
@aljesusg
Copy link
Contributor

I forgot I added #N to the commit but not in description my bad ^^. Thanks @tiffon

vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
@aljesusg
Fix link in scatter plot when embed mode jaegertracing#282 (jaegertra…
38fc7f7 
…cing#283)

Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tiffon @aljesusg