Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix link in scatter plot when embed mode #282 #283

Merged
merged 1 commit into from
Nov 28, 2018

Conversation

aljesusg
Copy link
Contributor

@aljesusg aljesusg commented Nov 28, 2018

Which problem is this PR solving?

#282

Short description of the changes

Fix link in the scatter plot to the trace with embed mode

fix_scatter_plot

@codecov
Copy link

codecov bot commented Nov 28, 2018

Codecov Report

Merging #283 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   77.45%   77.52%   +0.06%     
==========================================
  Files         137      137              
  Lines        2976     2976              
  Branches      617      617              
==========================================
+ Hits         2305     2307       +2     
+ Misses        529      528       -1     
+ Partials      142      141       -1
Impacted Files Coverage Δ
.../jaeger-ui/src/components/SearchTracePage/index.js 89.65% <100%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50592b...e1bbe6d. Read the comment docs.

Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
@aljesusg
Copy link
Contributor Author

@tiffon it's ready the fix :)

Copy link
Member

@tiffon tiffon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@tiffon tiffon merged commit fcd6bfd into jaegertracing:master Nov 28, 2018
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
…cing#283)

Signed-off-by: Alberto Gutierrez <aljesusg@gmail.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants